linux-kernel - Re: [PATCH] dh key: fix rounding up KDF output length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180607202831.GG9999@cisco>
Date:   Thu, 7 Jun 2018 14:28:31 -0600
From:   Tycho Andersen <tycho@...ho.ws>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     David Howells <dhowells@...hat.com>,
        James Morris <jmorris@...ei.org>, keyrings@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzkaller-bugs@...glegroups.com, Kees Cook <keescook@...omium.org>,
        Stephan Mueller <smueller@...onox.de>,
        Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH] dh key: fix rounding up KDF output length

On Thu, Jun 07, 2018 at 12:12:01PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Commit 383203eff718 ("dh key: get rid of stack allocated array") changed
> kdf_ctr() to assume that the length of key material to derive is a
> multiple of the digest size.  The length was supposed to be rounded up
> accordingly.  However, the round_up() macro was used which only gives
> the correct result on power-of-2 arguments, whereas not all hash
> algorithms have power-of-2 digest sizes.  In some cases this resulted in
> a write past the end of the 'outbuf' buffer.
> 
> Fix it by switching to roundup(), which works for non-power-of-2 inputs.
> 
> Reported-by: syzbot+486f97f892efeb2075a3@...kaller.appspotmail.com
> Reported-by: syzbot+29d17b7898b41ee120a5@...kaller.appspotmail.com
> Reported-by: syzbot+8a608baf8751184ec727@...kaller.appspotmail.com
> Reported-by: syzbot+d04e58bd384f1fe0b112@...kaller.appspotmail.com
> Fixes: 383203eff718 ("dh key: get rid of stack allocated array")
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Arg, thanks.

Acked-by: Tycho Andersen <tycho@...ho.ws>