linux-kernel - Re: [PATCH] block: Add block level changes for inline encryption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <918609fa-8721-0ee1-801e-4c29b64ac9ae@kernel.dk>
Date:   Wed, 6 Jun 2018 19:52:51 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Ladvine D Almeida <Ladvine.DAlmeida@...opsys.com>,
        Christoph Hellwig <hch@...radead.org>
Cc:     Hannes Reinecke <hare@...e.com>,
        "ming.lei@...hat.com" <ming.lei@...hat.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        linux-kernel@...r.kernel.org,
        Manjunath M Bettegowda <manjumb@...opsys.com>,
        Prabu Thangamuthu <prabut@...opsys.com>,
        Tejas Joglekar <joglekar@...opsys.com>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        Johannes Thumshirn <jthumshirn@...e.de>
Subject: Re: [PATCH] block: Add block level changes for inline encryption

On 6/6/18 1:35 AM, Ladvine D Almeida wrote:
> On Friday 01 June 2018 09:13 AM, Christoph Hellwig wrote:
>> On Mon, May 28, 2018 at 02:43:09PM +0100, Ladvine D Almeida wrote:
>>> This patch introduces new variable under bio structure to
>>> facilitate inline encryption. This variable is used to
>>> associate I/O requests to crypto information.
>> This seems to be missing a whole lot of context.  Where is the whole
>> series showing what you are trying to do?
>>
> Christoph,
> 
> The patches are generated in the below > manner, with a thought of
> sending separately to the MAINTAINERS responsible for each.

What both Christoph and I have said is that it's _impossible_ to review
changes when you don't know what is being built on top of it. The block
change, by itself, is utterly useless. The use case needs to be seen.
But apart from that, my comments on why it's doing it completely
backwards still apply, and I've outlined how you need to fix it. The
patch, in its current form, isn't going anywhere.

-- 
Jens Axboe