linux-kernel - Re: [PATCH 04/19] Bluetooth: hci_nokia: Add serdev_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <22CF0FC7-6DC7-4DD2-9EA1-9F51B40F53E5@holtmann.org>
Date:   Thu, 7 Jun 2018 14:32:08 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Pavel Machek <pavel@....cz>
Cc:     Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-serial@...r.kernel.org,
        Johan Hedberg <johan.hedberg@...il.com>,
        Rob Herring <robh@...nel.org>, Johan Hovold <johan@...nel.org>,
        linux-bluetooth@...r.kernel.org
Subject: Re: [PATCH 04/19] Bluetooth: hci_nokia: Add serdev_id_table

Hi Pavel,

>>> Describe which hardware is supported by the current driver.
>>> 
>>> Cc: Marcel Holtmann <marcel@...tmann.org>
>>> Cc: Johan Hedberg <johan.hedberg@...il.com>
>>> Cc: Rob Herring <robh@...nel.org>
>>> Cc: Johan Hovold <johan@...nel.org>
>>> Cc: linux-bluetooth@...r.kernel.org
>>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
>>> ---
>>> drivers/bluetooth/hci_nokia.c | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>> 
>>> diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c
>>> index 3539fd03f47e..e32dfcd56b8d 100644
>>> --- a/drivers/bluetooth/hci_nokia.c
>>> +++ b/drivers/bluetooth/hci_nokia.c
>>> @@ -801,6 +801,11 @@ static const struct of_device_id nokia_bluetooth_of_match[] = {
>>> MODULE_DEVICE_TABLE(of, nokia_bluetooth_of_match);
>>> #endif
>>> 
>>> +static struct serdev_device_id nokia_bluetooth_serdev_id[] = {
>>> +	{ "hp4-bluetooth", },
>>> +	{},
>>> +};
>>> +
>>> static struct serdev_device_driver nokia_bluetooth_serdev_driver = {
>>> 	.probe = nokia_bluetooth_serdev_probe,
>>> 	.remove = nokia_bluetooth_serdev_remove,
>>> @@ -809,6 +814,7 @@ static struct serdev_device_driver nokia_bluetooth_serdev_driver = {
>>> 		.pm = &nokia_bluetooth_pm_ops,
>>> 		.of_match_table = of_match_ptr(nokia_bluetooth_of_match),
>>> 	},
>>> +	.id_table = nokia_bluetooth_serdev_id,
>>> };
>> 
>> I would actually skip this hardware. First of all it is such a dedicated custom Nokia transport and hardware, and secondly it is no longer produced anyway.
>> 
> 
> Would it make sense to cc: sre here? We want good support even for old
> hardware, and this is n9/n950, it is still on "top ten supported
> phones" list... Probably even top 5.

but that is not what this patch series is about. We do not need new_id kinda support for the existing hardware. My point is there will be no newly designed hardware using this driver.

Regards

Marcel