linux-kernel - [PATCH 3.16 267/410] arm64: do not use print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lsq.1528380321.214381661@decadent.org.uk>
Date:   Thu, 07 Jun 2018 15:05:21 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     linux-kernel@...r.kernel.org, stable@...r.kernel.org
CC:     akpm@...ux-foundation.org,
        "Sergey Senozhatsky" <sergey.senozhatsky@...il.com>,
        linux-edac@...r.kernel.org, "Petr Mladek" <pmladek@...e.com>,
        linux-sh@...r.kernel.org, "Will Deacon" <will.deacon@....com>,
        linux-snps-arc@...ts.infradead.org,
        "Sergey Senozhatsky" <sergey.senozhatsky.work@...il.com>,
        linux-c6x-dev@...ux-c6x.org, x86@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-ia64@...r.kernel.org,
        "Catalin Marinas" <catalin.marinas@....com>,
        "Steven Rostedt" <rostedt@...dmis.org>, linux-am33-list@...hat.com
Subject: [PATCH 3.16 267/410] arm64: do not use print_symbol()

3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>

commit 4ef7963843d3243260aa335dfb9cb2fede06aacf upstream.

print_symbol() is a very old API that has been obsoleted by %pS format
specifier in a normal printk() call.

Replace print_symbol() with a direct printk("%pS") call.

Link: http://lkml.kernel.org/r/20171211125025.2270-3-sergey.senozhatsky@gmail.com
To: Andrew Morton <akpm@...ux-foundation.org>
To: Russell King <linux@...linux.org.uk>
To: Catalin Marinas <catalin.marinas@....com>
To: Mark Salter <msalter@...hat.com>
To: Tony Luck <tony.luck@...el.com>
To: David Howells <dhowells@...hat.com>
To: Yoshinori Sato <ysato@...rs.sourceforge.jp>
To: Guan Xuetao <gxt@...c.pku.edu.cn>
To: Borislav Petkov <bp@...en8.de>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Thomas Gleixner <tglx@...utronix.de>
To: Peter Zijlstra <peterz@...radead.org>
To: Vineet Gupta <vgupta@...opsys.com>
To: Fengguang Wu <fengguang.wu@...el.com>
Cc: Steven Rostedt <rostedt@...dmis.org>
Cc: Petr Mladek <pmladek@...e.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Cc: linux-arm-kernel@...ts.infradead.org
Cc: linux-c6x-dev@...ux-c6x.org
Cc: linux-ia64@...r.kernel.org
Cc: linux-am33-list@...hat.com
Cc: linux-sh@...r.kernel.org
Cc: linux-edac@...r.kernel.org
Cc: x86@...nel.org
Cc: linux-snps-arc@...ts.infradead.org
Cc: Catalin Marinas <catalin.marinas@....com>
Cc: Will Deacon <will.deacon@....com>
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
[pmladek@...e.com: updated commit message]
Signed-off-by: Petr Mladek <pmladek@...e.com>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
 arch/arm64/kernel/process.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -31,7 +31,6 @@
 #include <linux/delay.h>
 #include <linux/reboot.h>
 #include <linux/interrupt.h>
-#include <linux/kallsyms.h>
 #include <linux/init.h>
 #include <linux/cpu.h>
 #include <linux/elfcore.h>
@@ -198,8 +197,8 @@ void __show_regs(struct pt_regs *regs)
 	}
 
 	show_regs_print_info(KERN_DEFAULT);
-	print_symbol("pc : %s\n", regs->pc);
-	print_symbol("lr : %s\n", lr);
+	printk("pc : %pS\n", (void *)regs->pc);
+	printk("lr : %pS\n", (void *)lr);
 	printk("sp : %016llx pstate : %08llx\n", sp, regs->pstate);
 	for (i = top_reg; i >= 0; i--) {
 		printk("x%-2d: %016llx ", i, regs->regs[i]);