linux-kernel - Re: [PATCH 1/3] drm/bridge: Move the struct drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180607054530eucas1p2678c5763e1cf27f090aa007eb6b19399~1yoc6wQOZ2924329243eucas1p2u@eucas1p2.samsung.com>
Date:   Thu, 7 Jun 2018 07:45:28 +0200
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Eric Anholt <eric@...olt.net>, dri-devel@...ts.freedesktop.org,
        Archit Taneja <architt@...eaurora.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] drm/bridge: Move the struct drm_bridge member
 kerneldoc inline.

On 06.06.2018 21:04, Eric Anholt wrote:
> This makes it more likely that the docs stay updated with the code.
>
> Signed-off-by: Eric Anholt <eric@...olt.net>
Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>

 --
Regards
Andrzej
> ---
>  include/drm/drm_bridge.h | 22 ++++++++++++----------
>  1 file changed, 12 insertions(+), 10 deletions(-)
>
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index 70131ab57e8f..bd850747ce54 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -270,27 +270,29 @@ struct drm_bridge_timings {
>  
>  /**
>   * struct drm_bridge - central DRM bridge control structure
> - * @dev: DRM device this bridge belongs to
> - * @encoder: encoder to which this bridge is connected
> - * @next: the next bridge in the encoder chain
> - * @of_node: device node pointer to the bridge
> - * @list: to keep track of all added bridges
> - * @timings: the timing specification for the bridge, if any (may
> - * be NULL)
> - * @funcs: control functions
> - * @driver_private: pointer to the bridge driver's internal context
>   */
>  struct drm_bridge {
> +	/** @dev: DRM device this bridge belongs to */
>  	struct drm_device *dev;
> +	/** @encoder: encoder to which this bridge is connected */
>  	struct drm_encoder *encoder;
> +	/** @next: the next bridge in the encoder chain */
>  	struct drm_bridge *next;
>  #ifdef CONFIG_OF
> +	/** @of_node: device node pointer to the bridge */
>  	struct device_node *of_node;
>  #endif
> +	/** @list: to keep track of all added bridges */
>  	struct list_head list;
> +	/**
> +	 * @timings:
> +	 *
> +	 * the timing specification for the bridge, if any (may be NULL)
> +	 */
>  	const struct drm_bridge_timings *timings;
> -
> +	/** @funcs: control functions */
>  	const struct drm_bridge_funcs *funcs;
> +	/** @driver_private: pointer to the bridge driver's internal context */
>  	void *driver_private;
>  };
>