linux-kernel - Re: [RFC 0/1] mconf: Emacs-like isearch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ghmuw7uoku.fsf@lena.gouders.net>
Date:   Thu, 07 Jun 2018 07:56:33 +0200
From:   Dirk Gouders <dirk@...ders.net>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Segher Boessenkool <segher@...nel.crashing.org>
Subject: Re: [RFC 0/1] mconf: Emacs-like isearch

Masahiro Yamada <yamada.masahiro@...ionext.com> writes:

> 2018-06-07 8:54 GMT+09:00 Dirk Gouders <dirk@...ders.net>:
>> Randy Dunlap <rdunlap@...radead.org> writes:
>>
>>> On 06/06/2018 03:32 PM, Dirk Gouders wrote:
>>>> Randy Dunlap <rdunlap@...radead.org> writes:
>>>>
>>>>> On 06/06/2018 02:56 PM, Dirk Gouders wrote:
>>>>>> Hello,
>>>>>>
>>>>>> being an Emacs user, I frequently find myself pressing CTRL-s in mconf
>>>>>> to search for some menu entry, especially in large menus.
>
>
> I use Emacs, but I have never typed Ctrl-s in menuconfig.
>
> Is it important to use the same key pattern as in Emacs?
>
> You intercepted Ctrl-*
>
> Currently, Ctrl-C terminates the program,
> but this patch makes it no-op.

Yes, Segher also pointed out that I at least should have mentioned this
in the cover letter.  I simply forgot that, but I was aware that
forced raw-mode probably is not acceptable.

I'd say it's not important to start isearch with CTRL-s, I am just so
used to it.  So, I am open for suggestions.  Meanwhile, in a V2 I will
try to stay with CTRL-s (and probably another unused simpler key) but
also create a possibility to toggle raw-mode with default off.

>>>>>> I decided to implement a basic isearch in mconf and would like to hear
>>>>>> if others find this functionality useful, as well.
>>>>>>
>>>>>> The new functionality is started with pressing CTRL-s followed by
>>>>>> characters that form the search string.  To search for further
>>>>>> occurences of an entered string, press CTRL-s instead of further
>>>>>> characters.
>>>>>>
>>>>>> For example: to navigate to the USB device drivers, press CTRL-s de ENTER ENTER usb ENTER ENTER
>>>>>
>>>>> Not being an emacs user, what is the "de" for above?
>>>>
>>>> "de" (with my .config) causes a match for "Device Drivers" --
>>>> no other menu entry matching the string "de" is befor that entry.
>>>>
>>>
>>> Device Drivers is the first match for me also.
>>>
>>> To get to the USB drivers, I have to enter:
>>>       CTRL-s de ENTER ENTER CTRL-s usb ENTER ENTER
>>
>> Yes, I left out the second CTRL-s, thank you!
>>
>> Oh well, I shouldn't have sent this late at night, then I would probably
>> have explained the needed input as:
>>
>>      1) CTRL-s  // start isearch
>>      2) de      // substring that matches "Device Drivers"
>>      3) ENTER   // quit isearch
>>      4) ENTER   // enter Device Drivers menu
>>      5) CTRL-s  // start isearch
>>      6) usb     // navigate to USB support
>>      7) ENTER   // quit isearch
>>      8) ENTER   // enter USB support menu
>
>
> Hmm.
>
> I tried this, but I was a bit annoyed.
>
>
> I wonder if this could be more user-friendly.
>
> For example, I want KEY_UP/DOWN/LEFT/RIGHT
> to quit the search mode without pressing ENTER.

Thank you for testing it.  Concerning annoyance, did you mean the isearch
functionality itself or the incomplete implementation, i.e. the missing
possibility to use above keys?

I will handle the above keys in V2, additionally to fixing a problem
with mismatches.

Dirk