linux-kernel - Re: [RFC PATCH -tip v5 18/27] powerpc/kprobes: Don't call the ->break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1528389409.62iyaqw9yn.naveen@linux.ibm.com>
Date:   Thu, 07 Jun 2018 22:07:26 +0530
From:   "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        "H . Peter Anvin" <hpa@...or.com>, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        Ingo Molnar <mingo@...nel.org>, Ingo Molnar <mingo@...hat.com>,
        Paul Mackerras <paulus@...ba.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCH -tip v5 18/27] powerpc/kprobes: Don't call the
 ->break_handler() in arm kprobes code

Masami Hiramatsu wrote:
> On Thu, 07 Jun 2018 17:07:00 +0530
> "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com> wrote:
> 
>> Masami Hiramatsu wrote:
>> > Don't call the ->break_handler() from the arm kprobes code,
>> 					    ^^^ powerpc
>> 
>> > because it was only used by jprobes which got removed.
>> > 
>> > This also makes skip_singlestep() a static function since
>> > only ftrace-kprobe.c is using this function.
>> > 
>> > Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
>> > Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>> > Cc: Paul Mackerras <paulus@...ba.org>
>> > Cc: Michael Ellerman <mpe@...erman.id.au>
>> > Cc: "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
>> > Cc: linuxppc-dev@...ts.ozlabs.org
>> > ---
>> >  arch/powerpc/include/asm/kprobes.h   |   10 ----------
>> >  arch/powerpc/kernel/kprobes-ftrace.c |   16 +++-------------
>> >  arch/powerpc/kernel/kprobes.c        |   31 +++++++++++--------------------
>> >  3 files changed, 14 insertions(+), 43 deletions(-)
>> 
>> With 2 small comments...
> 
> 2 ? or 1 ?

Two, with one in the commit log above :)

- Naveen