linux-kernel - Re: [PATCH v5 21/31] kconfig: show compiler version text in the top comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdV9U1-3NsojpAZROAJsKSyun=RzFt6CqGAHwW3KHqi5kA@mail.gmail.com>
Date:   Fri, 8 Jun 2018 10:22:41 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-kbuild <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>,
        Nicholas Piggin <npiggin@...il.com>,
        "Luis R . Rodriguez" <mcgrof@...e.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Ulf Magnusson <ulfalizer@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v5 21/31] kconfig: show compiler version text in the top comment

Hi Yamada-san,

On Fri, Jun 8, 2018 at 9:04 AM, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
> 2018-06-07 17:58 GMT+09:00 Masahiro Yamada <yamada.masahiro@...ionext.com>:
>> 2018-06-07 17:42 GMT+09:00 Geert Uytterhoeven <geert@...ux-m68k.org>:
>>> On Mon, May 28, 2018 at 11:21 AM, Masahiro Yamada
>>> <yamada.masahiro@...ionext.com> wrote:
>>>> The kernel configuration phase is now tightly coupled with the compiler
>>>> in use.  It will be nice to show the compiler information in Kconfig.

[...]

>>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>>>> Reviewed-by: Kees Cook <keescook@...omium.org>
>>>
>>> This is now commit 21c54b774744719c ("kconfig: show compiler version text
>>> in the top comment") upstream.
>>>
>>> This commit broke cross-compilation for me:
>>>
>>>     $ make ARCH=m68k
>>>     scripts/kconfig/conf  --syncconfig Kconfig
>>>     scripts/kconfig/conf  --syncconfig Kconfig
>>>     scripts/kconfig/conf  --syncconfig Kconfig
>>>     scripts/kconfig/conf  --syncconfig Kconfig
>>>     ...
>>>
>>> with O=:
>>>
>>>       GEN     ./Makefile
>>>      scripts/kconfig/conf  --syncconfig Kconfig
>>>       GEN     ./Makefile
>>>     scripts/kconfig/conf  --syncconfig Kconfig
>>>       GEN     ./Makefile
>>>     scripts/kconfig/conf  --syncconfig Kconfig
>>>       GEN     ./Makefile
>>>     ...
>>>
>>> .config gained (both with/without O=):
>>>
>>>     #
>>>     # Compiler: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
>>>     #
>>>
>>> which is definitely wrong when cross-compiling for m68k.
>>>
>>> Reverting the commit, and fixing up the conflicts, fixes the issue for me
>>>
>>> Do you have a clue?
>>> Thanks!
>>
>>
>> Agh, I missed the case where CROSS_COMPILE is
>> set by arch/$(SRCARCH)/Makefile.
>>
>>
>> I will fix it.  Thanks for the report!
>
> I posted a patch.
> https://patchwork.kernel.org/patch/10453685/
>
> I hope it will fix your problem.

Yes it has. Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds