linux-kernel - Re: [PATCH] phy: phy-brcm-usb-init: Fix power down USB 3.0 PHY when XHCI reenabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <859be807-ab10-eae6-4e91-222e69c92a5e@gmail.com>
Date:   Fri, 8 Jun 2018 10:59:00 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jaedon Shin <jaedon.shin@...il.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Al Cooper <alcooperx@...il.com>
Cc:     linux-kernel@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH] phy: phy-brcm-usb-init: Fix power down USB 3.0 PHY when
 XHCI reenabled

On 06/07/2018 11:10 PM, Jaedon Shin wrote:
> Unset is required to enable USB 3.0 PHY when XHCI reenabled in response
> to setting PHY3_IDDQ_OVERRIDE in uninit().
> 
> Fixes: cd6f769fdea7 ("phy: phy-brcm-usb-init: Power down USB 3.0 PHY when XHCI disabled")
> Signed-off-by: Jaedon Shin <jaedon.shin@...il.com>

This does look valid, Al, can you review this as well? Thanks!

> ---
>  drivers/phy/broadcom/phy-brcm-usb-init.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/phy/broadcom/phy-brcm-usb-init.c b/drivers/phy/broadcom/phy-brcm-usb-init.c
> index 1b7febc43da9..29d2c3b1913a 100644
> --- a/drivers/phy/broadcom/phy-brcm-usb-init.c
> +++ b/drivers/phy/broadcom/phy-brcm-usb-init.c
> @@ -962,6 +962,10 @@ void brcm_usb_init_xhci(struct brcm_usb_init_params *params)
>  {
>  	void __iomem *ctrl = params->ctrl_regs;
>  
> +	USB_CTRL_UNSET(ctrl, USB30_PCTL, PHY3_IDDQ_OVERRIDE);
> +	/* 1 millisecond - for USB clocks to settle down */
> +	usleep_range(1000, 2000);
> +
>  	if (BRCM_ID(params->family_id) == 0x7366) {
>  		/*
>  		 * The PHY3_SOFT_RESETB bits default to the wrong state.
> 


-- 
Florian