linux-kernel - Re: [PATCH] trace: fix SKIP_STACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180608220759.irqviu5g4a3w7nms@two.firstfloor.org>
Date:   Fri, 8 Jun 2018 15:08:00 -0700
From:   Andi Kleen <andi@...stfloor.org>
To:     Greg Thelen <gthelen@...gle.com>
Cc:     Andi Kleen <andi@...stfloor.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        linux-kbuild@...r.kernel.org, akpm@...ux-foundation.org,
        Andi Kleen <ak@...ux.intel.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH] trace: fix SKIP_STACK_VALIDATION=1 build

On Fri, Jun 08, 2018 at 02:47:46PM -0700, Greg Thelen wrote:
> Non gcc-5 builds with CONFIG_STACK_VALIDATION=y and
> SKIP_STACK_VALIDATION=1 fail.
> Example output:
>   /bin/sh: init/.tmp_main.o: Permission denied
> 
> commit 96f60dfa5819 ("trace: Use -mcount-record for dynamic ftrace"),
> added a mismatched endif.  This causes cmd_objtool to get mistakenly
> set.
> 
> Relocate endif to balance the newly added -record-mcount check.
> 
> Fixes: 96f60dfa5819 ("trace: Use -mcount-record for dynamic ftrace")
> Signed-off-by: Greg Thelen <gthelen@...gle.com>

Looks good thanks.

Acked-by: Andi Kleen <ak@...ux.intel.com>

-Andi