linux-kernel - Re: [PATCH v3 02/10] PCI: dwc: Add MSI-X callbacks handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201806091903.eKRSYHmZ%fengguang.wu@intel.com>
Date:   Sat, 9 Jun 2018 21:22:51 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Gustavo Pimentel <gustavo.pimentel@...opsys.com>
Cc:     kbuild-all@...org, bhelgaas@...gle.com, lorenzo.pieralisi@....com,
        Joao.Pinto@...opsys.com, jingoohan1@...il.com, kishon@...com,
        adouglas@...ence.com, jesper.nilsson@...s.com,
        linux-pci@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>
Subject: Re: [PATCH v3 02/10] PCI: dwc: Add MSI-X callbacks handler

Hi Gustavo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pci/next]
[also build test ERROR on next-20180608]
[cannot apply to v4.17]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Gustavo-Pimentel/Add-MSI-X-support-on-pcitest-tool/20180609-143316
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=xtensa 

Note: the linux-review/Gustavo-Pimentel/Add-MSI-X-support-on-pcitest-tool/20180609-143316 HEAD 5d4d302fec65f168479852732f21aa886058d6c2 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

>> drivers/pci/dwc/pcie-designware-ep.c:359:16: error: initialization of 'int (*)(struct pci_epc *, u8,  enum pci_epc_irq_type,  u8)' {aka 'int (*)(struct pci_epc *, unsigned char,  enum pci_epc_irq_type,  unsigned char)'} from incompatible pointer type 'int (*)(struct pci_epc *, u8,  enum pci_epc_irq_type,  u16)' {aka 'int (*)(struct pci_epc *, unsigned char,  enum pci_epc_irq_type,  short unsigned int)'} [-Werror=incompatible-pointer-types]
     .raise_irq  = dw_pcie_ep_raise_irq,
                   ^~~~~~~~~~~~~~~~~~~~
   drivers/pci/dwc/pcie-designware-ep.c:359:16: note: (near initialization for 'epc_ops.raise_irq')
   cc1: some warnings being treated as errors
--
>> drivers/pci/dwc/pcie-artpec6.c:450:15: error: initialization of 'int (*)(struct dw_pcie_ep *, u8,  enum pci_epc_irq_type,  u16)' {aka 'int (*)(struct dw_pcie_ep *, unsigned char,  enum pci_epc_irq_type,  short unsigned int)'} from incompatible pointer type 'int (*)(struct dw_pcie_ep *, u8,  enum pci_epc_irq_type,  u8)' {aka 'int (*)(struct dw_pcie_ep *, unsigned char,  enum pci_epc_irq_type,  unsigned char)'} [-Werror=incompatible-pointer-types]
     .raise_irq = artpec6_pcie_raise_irq,
                  ^~~~~~~~~~~~~~~~~~~~~~
   drivers/pci/dwc/pcie-artpec6.c:450:15: note: (near initialization for 'pcie_ep_ops.raise_irq')
   cc1: some warnings being treated as errors

vim +359 drivers/pci/dwc/pcie-designware-ep.c

f8aed6ec Kishon Vijay Abraham I 2017-03-27  348  
f8aed6ec Kishon Vijay Abraham I 2017-03-27  349  static const struct pci_epc_ops epc_ops = {
f8aed6ec Kishon Vijay Abraham I 2017-03-27  350  	.write_header		= dw_pcie_ep_write_header,
f8aed6ec Kishon Vijay Abraham I 2017-03-27  351  	.set_bar		= dw_pcie_ep_set_bar,
f8aed6ec Kishon Vijay Abraham I 2017-03-27  352  	.clear_bar		= dw_pcie_ep_clear_bar,
f8aed6ec Kishon Vijay Abraham I 2017-03-27  353  	.map_addr		= dw_pcie_ep_map_addr,
f8aed6ec Kishon Vijay Abraham I 2017-03-27  354  	.unmap_addr		= dw_pcie_ep_unmap_addr,
f8aed6ec Kishon Vijay Abraham I 2017-03-27  355  	.set_msi		= dw_pcie_ep_set_msi,
f8aed6ec Kishon Vijay Abraham I 2017-03-27  356  	.get_msi		= dw_pcie_ep_get_msi,
797b96a7 Gustavo Pimentel       2018-06-08  357  	.set_msix		= dw_pcie_ep_set_msix,
797b96a7 Gustavo Pimentel       2018-06-08  358  	.get_msix		= dw_pcie_ep_get_msix,
f8aed6ec Kishon Vijay Abraham I 2017-03-27 @359  	.raise_irq		= dw_pcie_ep_raise_irq,
f8aed6ec Kishon Vijay Abraham I 2017-03-27  360  	.start			= dw_pcie_ep_start,
f8aed6ec Kishon Vijay Abraham I 2017-03-27  361  	.stop			= dw_pcie_ep_stop,
f8aed6ec Kishon Vijay Abraham I 2017-03-27  362  };
f8aed6ec Kishon Vijay Abraham I 2017-03-27  363  

:::::: The code at line 359 was first introduced by commit
:::::: f8aed6ec624fb436877a1a552393fd22510a5ff7 PCI: dwc: designware: Add EP mode support

:::::: TO: Kishon Vijay Abraham I <kishon@...com>
:::::: CC: Bjorn Helgaas <bhelgaas@...gle.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (53054 bytes)