linux-kernel - Re: [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180609061743.GE3593@linux.vnet.ibm.com>
Date:   Fri, 8 Jun 2018 23:17:44 -0700
From:   "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org
Subject: Re: [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse:
 symbol 'stupid_workaround' was not declared. Should it be static?

On Sat, Jun 09, 2018 at 04:11:26AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/dev
> head:   f20dfe840ba05efdc4071106cffa31cb67cf6bc8
> commit: 814ee31d1f906ad00daccb58944ab16fa279690c [114/116] fixup! EXP iommu: Placeholder for fix in mainline
> reproduce:
>         # apt-get install sparse
>         git checkout 814ee31d1f906ad00daccb58944ab16fa279690c
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF=-D__CHECK_ENDIAN__
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
>    drivers/iommu/amd_iommu.c:3539:30: sparse: expression using sizeof(void)
>    drivers/iommu/amd_iommu.c:3542:36: sparse: expression using sizeof(void)
>    drivers/iommu/amd_iommu.c:3542:36: sparse: expression using sizeof(void)
> >> drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static?
> 
> Please review and possibly fold the followup patch.

This whole thing disappears when I rebase to v4.18-rc1.  ;-)

							Thanx, Paul