linux-kernel - Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2h8mc4ejw.fsf@linux-m68k.org>
Date:   Sat, 09 Jun 2018 09:14:27 +0200
From:   Andreas Schwab <schwab@...ux-m68k.org>
To:     Michael Schmitz <schmitzmic@...il.com>
Cc:     Finn Thain <fthain@...egraphics.com.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        linuxppc-dev@...ts.ozlabs.org, linux-m68k@...ts.linux-m68k.org,
        linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

On Jun 09 2018, Michael Schmitz <schmitzmic@...il.com> wrote:

> Hi Finn,
>
> Am 08.06.2018 um 14:24 schrieb Finn Thain:
>> Don't load the via-pmu68k driver on early PowerBooks. The M50753 PMU
>> device found in those models was never supported by this driver.
>> Attempting to load the driver usually causes a boot hang.
>>
>> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
>> ---
>>  arch/m68k/mac/misc.c           | 6 ++----
>>  drivers/macintosh/via-pmu68k.c | 4 ----
>>  include/uapi/linux/pmu.h       | 1 -
>>  3 files changed, 2 insertions(+), 9 deletions(-)
> ...
>> diff --git a/include/uapi/linux/pmu.h b/include/uapi/linux/pmu.h
>> index 89cb1acea93a..30f64d46f5db 100644
>> --- a/include/uapi/linux/pmu.h
>> +++ b/include/uapi/linux/pmu.h
>> @@ -93,7 +93,6 @@ enum {
>>  	PMU_HEATHROW_BASED,	/* PowerBook G3 series */
>>  	PMU_PADDINGTON_BASED,	/* 1999 PowerBook G3 */
>>  	PMU_KEYLARGO_BASED,	/* Core99 motherboard (PMU99) */
>> -	PMU_68K_V1,		/* 68K PMU, version 1 */
>>  	PMU_68K_V2, 		/* 68K PMU, version 2 */
>>  };
>
> Is this enum used by any user space code? If so, perhaps rather leave the
> PMU_68K_V1 in there to avoid upsetting that?

It also changes the value of PMU_68K_V2, which is an ABI break.

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."