linux-kernel - Re: [PATCH -next] media/platform/cadence: add <linux/slab.h> to fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180611073647.6j4wsvoh4ceavpih@flea>
Date:   Mon, 11 Jun 2018 09:36:47 +0200
From:   Maxime Ripard <maxime.ripard@...tlin.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-media <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH -next] media/platform/cadence: add <linux/slab.h> to fix
 build error

On Fri, Jun 08, 2018 at 02:19:06PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Add #include <linux/slab.h> to fix build errors.
> This driver uses kzalloc() and kfree() so it needs to #include
> the appropriate header file for those interfaces.
> 
> Fixes these build errors:
> 
> ../drivers/media/platform/cadence/cdns-csi2rx.c: In function 'csi2rx_probe':
> ../drivers/media/platform/cadence/cdns-csi2rx.c:421:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
>   csi2rx = kzalloc(sizeof(*csi2rx), GFP_KERNEL);
> ../drivers/media/platform/cadence/cdns-csi2rx.c:421:9: warning: assignment makes pointer from integer without a cast [enabled by default]
>   csi2rx = kzalloc(sizeof(*csi2rx), GFP_KERNEL);
> ../drivers/media/platform/cadence/cdns-csi2rx.c:466:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
>   kfree(csi2rx);
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Maxime Ripard <maxime.ripard@...tlin.com>

Acked-by: Maxime Ripard <maxime.ripard@...tlin.com>

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)