linux-kernel - Re: [RFC PATCH v1 0/9] PCI/portdrv: Squash into one file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Jun 2018 13:47:26 +0530
From:   poza@...eaurora.org
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v1 0/9] PCI/portdrv: Squash into one file

On 2018-06-09 01:42, Bjorn Helgaas wrote:
> The portdrv code is scattered across several files, which makes it a 
> bit of
> a hassle to browse.  Consolidate it all in a single file.
> 

Although I do not have any objection is merging the code,

It looks to me that the 2 files served purpose of keeping
portdrv device functionality in  one file > portdrv_pci.c
while, port driver helper and exported service functions for services 
are in > portdrv_core.c

If that was the original intention, it just looks okay to me.
But I am not sure the way the code is now, we can call is scattered,
and also I do not think by merging it, we can call it more organised.

although certainly it looks easier to browse as you are suggesting.
little less confusing.

> This is all pure code moves; no functional changes intended.  Well, 
> there
> is a function rename, but it shouldn't change any behavior.
> 
> ---
> 
> Bjorn Helgaas (9):
>       PCI/portdrv: Rename resume_iter() to prevent name collision
>       PCI/portdrv: Squash pieces of portdrv_core.c into portdrv_pci.c
>       PCI/portdrv: Squash PM-related code into portdrv_pci.c
>       PCI/portdrv: Squash device removal code into portdrv_pci.c
>       PCI/portdrv: Squash lookup interfaces into portdrv_pci.c
>       PCI/portdrv: Squash service driver registration into 
> portdrv_pci.c
>       PCI/portdrv: Move private definitions to portdrv_pci.c
>       PCI/portdrv: Clean up whitespace
>       PCI/portdrv: Rename portdrv_pci.c to portdrv.c
> 
> 
>  drivers/pci/pcie/Makefile       |    6
>  drivers/pci/pcie/portdrv.c      |  822 
> +++++++++++++++++++++++++++++++++++++++
>  drivers/pci/pcie/portdrv.h      |   15 -
>  drivers/pci/pcie/portdrv_core.c |  578 ---------------------------
>  drivers/pci/pcie/portdrv_pci.c  |  261 ------------
>  5 files changed, 824 insertions(+), 858 deletions(-)
>  create mode 100644 drivers/pci/pcie/portdrv.c
>  delete mode 100644 drivers/pci/pcie/portdrv_core.c
>  delete mode 100644 drivers/pci/pcie/portdrv_pci.c