[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJfpegt5guR3zJeATw4-N41Ad2n9pcB5mQoLmSLOfocnEoodVg@mail.gmail.com>
Date: Mon, 11 Jun 2018 11:15:55 +0200
From: Miklos Szeredi <miklos@...redi.hu>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: Miklos Szeredi <mszeredi@...hat.com>,
overlayfs <linux-unionfs@...r.kernel.org>,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/11] vfs: factor out inode_insert5()
On Sun, Jun 10, 2018 at 8:02 AM, Al Viro <viro@...iv.linux.org.uk> wrote:
> On Sun, Jun 10, 2018 at 06:49:10AM +0100, Al Viro wrote:
>> On Tue, May 29, 2018 at 04:41:41PM +0200, Miklos Szeredi wrote:
>> > From: Miklos Szeredi <miklos@...redi.hu>
>> >
>> > Split out common helper for race free insertion of an already allocated
>> > inode into the cache. Use this from iget5_locked() and
>> > insert_inode_locked4(). Make iget5_locked() use new_inode()/iput() instead
>> > of alloc_inode()/destroy_inode() directly.
>>
>> ... thus hitting the sucker with ->evict_inode(), in condition that is quite
>> likely to be unfit to be seen by that.
>>
>> NAK.
>
> To clarify: objection here is against the switch to new_inode/iput. The rest is
> sane. What makes new_inode() better here, anyway?
Umm, got to look into this. The patch has already been pulled by
Linus, but I hope it's salvageable.
Thanks,
Miklos
Powered by blists - more mailing lists