linux-kernel - Re: [PATCH] kernel/hung_task.c: allow to set period separately from timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8171ca9e-54c4-46bd-803b-cf0b9aa03303@i-love.sakura.ne.jp>
Date:   Mon, 11 Jun 2018 21:48:56 +0900
From:   Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
To:     Dmitry Vyukov <dvyukov@...gle.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Paul McKenney <paulmck@...ux.vnet.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>,
        syzkaller <syzkaller@...glegroups.com>
Subject: Re: [PATCH] kernel/hung_task.c: allow to set period separately from
 timeout

On 2018/06/11 20:16, Dmitry Vyukov wrote:
>> timeout = 60 and period = 1 would allow hung task to be reported as soon
>> as it remained uninterruptible for 60 seconds. That makes me easier to
>> narrow down relevant kernel messages and syzbot program.
>>
>> Well, showing exact slept time, along with all threads which slept more
>> than some threshold (e.g. timeout / 2), might be helpful.
> 
> You mean if we report any task, then scan all tasks second time and
> additionally report tasks that are blocked for (timeout/2 : timeout)?

Yes. Something like check_memalloc_stalling_tasks() in
http://lkml.kernel.org/r/1495331504-12480-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp .

> 
> Should we do this when hung_task_show_lock? Or only when
> sysctl_hung_task_panic? Or when?
> 

I think always is more useful. That is, first round only checks whether
there is at least one stalling task, and second round reports stalling tasks
if at least one task is stalling.