linux-kernel - Re: [PATCH 07/13] memcontrol: schedule throttling if we are congested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180611140858.GB1507@cmpxchg.org>
Date:   Mon, 11 Jun 2018 10:08:58 -0400
From:   Johannes Weiner <hannes@...xchg.org>
To:     Josef Bacik <josef@...icpanda.com>
Cc:     axboe@...nel.dk, kernel-team@...com, linux-block@...r.kernel.org,
        akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        tj@...nel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 07/13] memcontrol: schedule throttling if we are congested

On Tue, Jun 05, 2018 at 09:29:42AM -0400, Josef Bacik wrote:
> From: Tejun Heo <tj@...nel.org>
> 
> Memory allocations can induce swapping via kswapd or direct reclaim.  If
> we are having IO done for us by kswapd and don't actually go into direct
> reclaim we may never get scheduled for throttling.  So instead check to
> see if our cgroup is congested, and if so schedule the throttling.
> Before we return to user space the throttling stuff will only throttle
> if we actually required it.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>

Looks good to me now, thanks.

Acked-by: Johannes Weiner <hannes@...xchg.org>