linux-kernel - Re: [PATCH v6 4/5] clocksource: add driver for i.MX EPIT timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27c914a5-22b2-1f64-dc89-4ecee5bff2b9@mleia.com>
Date:   Mon, 11 Jun 2018 17:40:02 +0300
From:   Vladimir Zapolskiy <vz@...ia.com>
To:     Clément Péron <peron.clem@...il.com>,
        Colin Didier <colin.didier@...ialet.com>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Rob Herring <robh@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Clément Peron <clement.peron@...ialet.com>
Subject: Re: [PATCH v6 4/5] clocksource: add driver for i.MX EPIT timer

On 06/07/2018 05:05 PM, Clément Péron wrote:
> From: Colin Didier <colin.didier@...ialet.com>
> 
> Add driver for NXP's EPIT timer used in i.MX SoC.
> 
> Signed-off-by: Colin Didier <colin.didier@...ialet.com>
> Signed-off-by: Clément Peron <clement.peron@...ialet.com>

Reviewed-by: Vladimir Zapolskiy <vz@...ia.com>
Tested-by: Vladimir Zapolskiy <vz@...ia.com>

I tested the driver on i.MX31 only, and I didn't find any problems.

Please fix the indentation issue found by Stefan in v7.

Regarding utilization of timer-of.c it can be postponed IMHO,
but it's up to clocksource maintainers and you to decide, and if
you do such an update for v7, then please don't add my tags,
I'll review and test it again.

--
With best wishes,
Vladimir