linux-kernel - Re: PATCH fixed coding style error in drivers/bluetooth/hci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Jun 2018 09:37:44 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     jagadish tirumala <t.jag587@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: PATCH fixed coding style error in drivers/bluetooth/hci_serdev.c

On Mon, Jun 11, 2018 at 08:15:13AM -0700, jagadish tirumala wrote:
> 
> HI , This is Jagdish , I have fixed a coding style ERROR: space required
> before the open parenthesis in drivers/bluetooth/hci_serdev.c , please
> have a look
> 
> Jagdish
> 
> 
>

Hello Jagdish,

I am afraid your patch has several problems and won't be considered (nor
accepted) by the community.  First the patch can't be an attachment to an email
- please see how patches are posted on the kernel mailing list and use a tool
 like "git send-email".

Second you need to send the patch to the maintainers and CC the kernel mailing
list.  Otherwise it is very unlikey the person who is supposed to look at your
patch will actually do so.  A tool like script/get_maintainer.pl will help you
with that.

> From 3c3e844d0f0ba49a6d40a7265548f81316f756e4 Mon Sep 17 00:00:00 2001
> From: Jagdish587 <t.jag587@...il.com>
> Date: Sun, 10 Jun 2018 04:15:53 -0700
> Subject: [PATCH 1/1] fixed coding style error

We can do better here.  git log --oneline -10 drivers/bluetooth/hci_serdev.c
will give you examples of the title other people have given to their patches
when submitting fix that touch this file.

> 
> Signed-off-by: Jagdish587 <t.jag587@...il.com>

This needs to be the name you would use to sign documents.

I suggest you familiarise yourself with chapter 1 to 8 in
Documentation/process/.  This will save you a lot of time.

Mathieu

> ---
>  drivers/bluetooth/hci_serdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c
> index aa2543b..d41c520 100644
> --- a/drivers/bluetooth/hci_serdev.c
> +++ b/drivers/bluetooth/hci_serdev.c
> @@ -94,7 +94,7 @@ static void hci_uart_write_work(struct work_struct *work)
>  			hci_uart_tx_complete(hu, hci_skb_pkt_type(skb));
>  			kfree_skb(skb);
>  		}
> -	} while(test_bit(HCI_UART_TX_WAKEUP, &hu->tx_state));
> +	} while (test_bit(HCI_UART_TX_WAKEUP, &hu->tx_state));
>  
>  	clear_bit(HCI_UART_SENDING, &hu->tx_state);
>  }
> -- 
> 2.7.4
> 
> 
>