linux-kernel - REGRESSION?: debugfs: inode: debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Jun 2018 15:40:41 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Thomas Richter <tmricht@...ux.ibm.com>
Cc:     Kees Cook <keescook@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: REGRESSION?: debugfs: inode: debugfs_create_dir uses mode permission
 from parent

Hey all,
  I noticed recently that linus/master (plus patches) stopped booting
to UI on HiKey960, and I bisected the issue down to:
92170b62f1c1 ("debugfs: inode: debugfs_create_dir uses mode permission
from parent")

On the HiKey960 board, we mount debugfs via:
   mount debugfs /sys/kernel/debug /sys/kernel/debug mode=755

But since the change, it seems most of the nodes in /sys/kernel/debug
are: drwx------

Which ends up breaking the egl library, keeping it from loading.

This seems to be the expected behavior of the patch, but I'm surprised
the mode override is now ignored. It seems like the potential fix here
would be to set the /sys/kernel/debug dir to 755 prior to mounting? Or
is there some other advised solution?

thanks
-john