linux-kernel - Re: REGRESSION?: debugfs: inode: debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLWNhAR3T6UfobdPfiVX9HQ_h9aehrkV8n+4H9s2Q6fy9g@mail.gmail.com>
Date:   Tue, 12 Jun 2018 15:53:58 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Laura Abbott <labbott@...hat.com>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: REGRESSION?: debugfs: inode: debugfs_create_dir uses mode
 permission from parent

On Tue, Jun 12, 2018 at 3:52 PM, Kees Cook <keescook@...omium.org> wrote:
> On Tue, Jun 12, 2018 at 3:40 PM, John Stultz <john.stultz@...aro.org> wrote:
>> Hey all,
>>   I noticed recently that linus/master (plus patches) stopped booting
>> to UI on HiKey960, and I bisected the issue down to:
>> 92170b62f1c1 ("debugfs: inode: debugfs_create_dir uses mode permission
>> from parent")
>>
>> On the HiKey960 board, we mount debugfs via:
>>    mount debugfs /sys/kernel/debug /sys/kernel/debug mode=755
>>
>> But since the change, it seems most of the nodes in /sys/kernel/debug
>> are: drwx------
>>
>> Which ends up breaking the egl library, keeping it from loading.
>>
>> This seems to be the expected behavior of the patch, but I'm surprised
>> the mode override is now ignored. It seems like the potential fix here
>> would be to set the /sys/kernel/debug dir to 755 prior to mounting? Or
>> is there some other advised solution?
>
> This change has already be reverted from other people reporting the
> problem. Perhaps the root cause is the lack of propagation of the
> mode= value?

Ah! Thanks, sorry for not searching for the earlier discussion.

thanks
-john