linux-kernel - Re: [PATCH] proc: add error handling for kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180612050937.GA2985@avx2>
Date:   Tue, 12 Jun 2018 08:09:38 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     Zhouyang Jia <jiazhouyang09@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] proc: add error handling for kmem_cache_create

On Tue, Jun 12, 2018 at 12:23:52PM +0800, Zhouyang Jia wrote:
> When kmem_cache_create fails, the lack of error-handling code may
> cause unexpected results.
> 
> This patch adds error-handling code after calling kmem_cache_create.

>  	pde_opener_cache =
>  		kmem_cache_create("pde_opener", sizeof(struct pde_opener), 0,
>  				  SLAB_ACCOUNT|SLAB_PANIC, NULL);
> +	if (!proc_inode_cachep || !pde_opener_cache)
> +		return -ENOMEM;

SLAB_PANIC was added to not worry about error handling.