linux-kernel - Re: [PATCH] ASoC: twl6040: make pointer dmic_codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0355575-feb2-a1fe-242a-57acf52bad1e@ti.com>
Date:   Tue, 12 Jun 2018 10:46:56 +0300
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     Colin King <colin.king@...onical.com>,
        Jarkko Nikula <jarkko.nikula@...mer.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <linux-omap@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: twl6040: make pointer dmic_codec_dev static

Hi,

On 2018-06-06 12:35, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The pointer dmic_codec_dev is local to the source and does not need
> to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> warning: symbol 'dmic_codec_dev' was not declared. Should it be static?

can you change the subject to:
ASoC: omap-abe-twl6040: make pointer dmic_codec_dev static

With that change:
Acked-by: Peter Ujfalusi <peter.ujfalusi@...com>

> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  sound/soc/omap/omap-abe-twl6040.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/omap/omap-abe-twl6040.c b/sound/soc/omap/omap-abe-twl6040.c
> index 15ccbf479c96..d5ae9eb8c756 100644
> --- a/sound/soc/omap/omap-abe-twl6040.c
> +++ b/sound/soc/omap/omap-abe-twl6040.c
> @@ -40,7 +40,7 @@ struct abe_twl6040 {
>  	int	mclk_freq;	/* MCLK frequency speed for twl6040 */
>  };
>  
> -struct platform_device *dmic_codec_dev;
> +static struct platform_device *dmic_codec_dev;
>  
>  static int omap_abe_hw_params(struct snd_pcm_substream *substream,
>  	struct snd_pcm_hw_params *params)
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki