linux-kernel - Re: [PATCH] usb: dwc2: gadget: fix packet drop issue in dwc2_gadget_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Jun 2018 07:48:25 +0000
From:   Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
To:     Zeng Tao <prime.zeng@...ilicon.com>,
        "Minas.Harutyunyan@...opsys.com" <Minas.Harutyunyan@...opsys.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc2: gadget: fix packet drop issue in
 dwc2_gadget_handle_nak

Acked-by: Minas Harutyunyan <hminas@...opsys.com>

On 6/12/2018 10:51 AM, Zeng Tao wrote:
> In ISOC transfer, when the NAK interrupt happens, we shouldn't complete
> a usb request, the current flow will complete one usb request with no
> hardware transfer, this will lead to a packet drop on the usb bus.
> 
> Signed-off-by: Zeng Tao <prime.zeng@...ilicon.com>
> ---
>   drivers/usb/dwc2/gadget.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index f0d9ccf..fbe65f6 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -2817,9 +2817,6 @@ static void dwc2_gadget_handle_nak(struct dwc2_hsotg_ep *hs_ep)
>   
>   		tmp = dwc2_hsotg_read_frameno(hsotg);
>   		if (using_desc_dma(hsotg)) {
> -			dwc2_hsotg_complete_request(hsotg, hs_ep,
> -						    get_ep_head(hs_ep), 0);
> -
>   			hs_ep->target_frame = tmp;
>   			dwc2_gadget_incr_frame_num(hs_ep);
>   			dwc2_gadget_start_isoc_ddma(hs_ep);
>