linux-kernel - Re: [PATCH] dmaengine: rcar-dmac: don't use DMAC error interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87muw0qvfo.wl%kuninori.morimoto.gx@renesas.com>
Date:   Tue, 12 Jun 2018 08:12:15 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     <vkoul@...nel.org>, Dan Williams <dan.j.williams@...el.com>,
        Magnus Damm <magnus.damm@...il.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Kieran Bingham <kieran@...uared.org.uk>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        <dmaengine@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: rcar-dmac: don't use DMAC error interrupt


Hi Geert

Thank you for your light speed review :)

> > From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> >
> > Current rcar-dmac is using DMAC error interrupt which will handle all
> > channel's error. But in this design, error handling itself will be
> > issue if user want to use virtualization, multi OS, etc.
> > This patch removes current DMAC error interrupt handling, and handle it
> > on each channel interrupt handler.
> >
> > Signed-off-by: Magnus Damm <damm+renesas@...nsource.se>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> 
> Who wrote this patch, you or Magnus? Or is this a joint effort?

Original was Magnus, and I updated it.
I think I need to add such things.

> > --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> > +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> > @@ -35,9 +35,8 @@ Required Properties:
> >
> >  - interrupts: interrupt specifiers for the DMAC, one for each entry in
> >    interrupt-names.
> > -- interrupt-names: one entry for the error interrupt, named "error", plus one
> > -  entry per channel, named "ch%u", where %u is the channel number ranging from
> > -  zero to the number of channels minus one.
> > +- interrupt-names: one entry per channel, named "ch%u", where %u is the
> > +  channel number ranging from zero to the number of channels minus one.
> 
> DT bindings describe hardware, not software policy.
> So IMHO the error interrupt must not be removed from the bindings (and
> from the DTS and example).

IC

> The rest looks good to me (but I haven't tested it), so with the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Thanks. Will post v2 tomorrow

Best regards
---
Kuninori Morimoto