linux-kernel - Re: [PATCH] gfs2: add error handling for kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHc6FU6M0dOnJOuJ9ffP22Qbd0tkQ3mPqt7BexjeJ4rPPJdz8w@mail.gmail.com>
Date:   Tue, 12 Jun 2018 10:23:30 +0200
From:   Andreas Gruenbacher <agruenba@...hat.com>
To:     "cgxu519@....com" <cgxu519@....com>
Cc:     Zhouyang Jia <jiazhouyang09@...il.com>,
        Bob Peterson <rpeterso@...hat.com>,
        cluster-devel <cluster-devel@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gfs2: add error handling for kmem_cache_zalloc

On 12 June 2018 at 09:24, cgxu519@....com <cgxu519@....com> wrote:
>
>> 在 2018年6月12日，上午11:38，Zhouyang Jia <jiazhouyang09@...il.com> 写道：
>>
>> When kmem_cache_zalloc fails, the lack of error-handling code may
>> cause unexpected results.
>>
>> This patch adds error-handling code after calling kmem_cache_zalloc.
>
> Should not fail on this case.

Indeed, with the __GFP_NOFAIL flag, kmem_cache_zalloc will not fail.
This is documented in include/linux/gfp.h.

Thanks,
Andreas