linux-kernel - Re: [PATCH] gpio: Fix wrong rounding in gpio-menz127

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbqDKAkxjY1NsUpJ=UR0MVGivUdQz+BE-7MXXjZYa04bw@mail.gmail.com>
Date:   Tue, 12 Jun 2018 10:40:22 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Nadav Amit <namit@...are.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: Fix wrong rounding in gpio-menz127

On Mon, Jun 4, 2018 at 3:58 PM, Nadav Amit <namit@...are.com> wrote:

> men_z127_debounce() tries to round up and down, but uses functions which
> are only suitable when the divider is a power of two, which is not the
> case. Use the appropriate ones.
>
> Found by static check. Compile tested.
>
> Fixes: f436bc2726c64 ("gpio: add driver for MEN 16Z127 GPIO controller")
>
> Signed-off-by: Nadav Amit <namit@...are.com>

Applied as a non-critical fix as I have not error reports.

Yours,
Linus Walleij