linux-kernel - Re: [PATCH v6 08/11] cpufreq/schedutil: take into account interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtCCi665e45Ar52VLvaeem4Acin0jgo_563nAhYEkhHacw@mail.gmail.com>
Date:   Tue, 12 Jun 2018 11:10:18 +0200
From:   Vincent Guittot <vincent.guittot@...aro.org>
To:     Dietmar Eggemann <dietmar.eggemann@....com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Juri Lelli <juri.lelli@...hat.com>,
        Morten Rasmussen <Morten.Rasmussen@....com>,
        viresh kumar <viresh.kumar@...aro.org>,
        Valentin Schneider <valentin.schneider@....com>,
        Patrick Bellasi <patrick.bellasi@....com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Quentin Perret <quentin.perret@....com>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v6 08/11] cpufreq/schedutil: take into account interrupt

On 12 June 2018 at 10:54, Dietmar Eggemann <dietmar.eggemann@....com> wrote:
> On 06/08/2018 02:09 PM, Vincent Guittot wrote:
>
> [...]
>
>> @@ -182,21 +183,30 @@ static void sugov_get_util(struct sugov_cpu *sg_cpu)
>>         sg_cpu->util_dl  = cpu_util_dl(rq);
>>         sg_cpu->bw_dl    = cpu_bw_dl(rq);
>>         sg_cpu->util_rt  = cpu_util_rt(rq);
>> +       sg_cpu->util_irq = cpu_util_irq(rq);
>>   }
>>     static unsigned long sugov_aggregate_util(struct sugov_cpu *sg_cpu)
>>   {
>>         struct rq *rq = cpu_rq(sg_cpu->cpu);
>> -       unsigned long util;
>> +       unsigned long util, max = sg_cpu->max;
>>         if (rq->rt.rt_nr_running)
>>                 return sg_cpu->max;
>>   +     if (unlikely(sg_cpu->util_irq >= max))
>> +               return max;
>> +
>> +       /* Sum rq utilization */
>>         util = sg_cpu->util_cfs;
>>         util += sg_cpu->util_rt;
>>   -     if ((util + sg_cpu->util_dl) >= sg_cpu->max)
>> -               return sg_cpu->max;
>> :confirm b9
>
>
> This didn't let me apply the patch ;-) After removing this line it worked.

Argh ... i have done something wrong
I'm going to resend it
>
> [...]