linux-kernel - Re: [PATCH] inotify: add error handling for kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwPUoz5uz+nxvjBo9nw2fNYcCJRk2-aCzPNcrCzg9-383D7AA@mail.gmail.com>
Date:   Tue, 12 Jun 2018 17:53:12 +0800
From:   Kassey <kassey1216@...il.com>
To:     "cgxu519@....com" <cgxu519@....com>
Cc:     Zhouyang Jia <jiazhouyang09@...il.com>, Jan Kara <jack@...e.cz>,
        Amir Goldstein <amir73il@...il.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] inotify: add error handling for kmem_cache_create

in __kmem_cache_create->kmem_cache_open

with SLAB_PANIC, kernel will panic if it fail

On Tue, Jun 12, 2018 at 3:41 PM, cgxu519@....com <cgxu519@....com> wrote:
>
>> 在 2018年6月12日，下午12:22，Zhouyang Jia <jiazhouyang09@...il.com> 写道：
>>
>> When kmem_cache_create fails, the lack of error-handling code may
>> cause unexpected results.
>>
>> This patch adds error-handling code after calling kmem_cache_create.
>
> I think SLAB_PANIC can handle this case.
>
> Thanks,
> Chengguang.
>
>>
>> Signed-off-by: Zhouyang Jia <jiazhouyang09@...il.com>
>> ---
>> fs/notify/inotify/inotify_user.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
>> index ef32f36..0704bab 100644
>> --- a/fs/notify/inotify/inotify_user.c
>> +++ b/fs/notify/inotify/inotify_user.c
>> @@ -805,6 +805,8 @@ static int __init inotify_user_setup(void)
>>       BUG_ON(hweight32(ALL_INOTIFY_BITS) != 21);
>>
>>       inotify_inode_mark_cachep = KMEM_CACHE(inotify_inode_mark, SLAB_PANIC);
>> +     if (!inotify_inode_mark_cachep)
>> +             return -ENOMEM;
>>
>>       inotify_max_queued_events = 16384;
>>       init_user_ns.ucount_max[UCOUNT_INOTIFY_INSTANCES] = 128;
>> --
>> 2.7.4
>>
>



-- 
Best regards
Kassey