linux-kernel - Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180612110048.GA10819@sirena.org.uk>
Date:   Tue, 12 Jun 2018 12:00:48 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Alexander Shiyan <shc_work@...l.ru>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Tony Lindgren <tony@...mide.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Philipp Zabel <philipp.zabel@...il.com>,
        Daniel Mack <zonque@...il.com>,
        Marc Zyngier <marc.zyngier@....com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO
 descriptor only

On Tue, Jun 12, 2018 at 10:15:40AM +0200, Linus Walleij wrote:
> On Mon, Jun 11, 2018 at 5:00 PM, Mark Brown <broonie@...nel.org> wrote:
> > On Mon, Jun 11, 2018 at 03:11:14PM +0200, Linus Walleij wrote:

> >> Sadly this only handled the undocumented fixed
> >> regulator binding "reg-fixed-voltage". So I need to fix it
> >> for "regulator-fixed" as well, and then it "should work".

> > The normal fixed voltage regulator parses enable-active-high?

> Yeah currently. However I moved the handling to the gpiolib
> parsing code to centralize polarity inversion handling, in an
> attempt so keep things under control. So in the patch series
> this flag handling moves over to the gpiolib.

Ah, I see - you're talking about the series rather than the current
state of the code, I thought you were talking about the current state of
the code which was why I was confused.

> I was thinking to do the same with other subsystems, such as
> MMC to get legacy GPIO flags under control and contained.

Yes, it'd be good to try to make this clearer for users - having so many
ways of specifying the same thing makes everything hard to understand.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)