linux-kernel - Re: [PATCH] cpufreq: ACPI: make function acpi_cpufreq_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1707897.EI8LSjriHK@aspire.rjw.lan>
Date:   Tue, 12 Jun 2018 17:00:55 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Colin King <colin.king@...onical.com>
Cc:     linux-pm@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: ACPI: make function acpi_cpufreq_fast_switch static

On Monday, June 4, 2018 9:11:41 AM CEST Viresh Kumar wrote:
> On 01-06-18, 14:05, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > The function acpi_cpufreq_fast_switch is local to the source and does
> > not need to be in global scope, so make it static.
> > 
> > Cleans up sparse warning:
> > drivers/cpufreq/acpi-cpufreq.c:468:14: warning: symbol
> > 'acpi_cpufreq_fast_switch' was not declared. Should it be static?
> > 
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> > ---
> >  drivers/cpufreq/acpi-cpufreq.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> > index 9449657d72f0..32ba4bc972e7 100644
> > --- a/drivers/cpufreq/acpi-cpufreq.c
> > +++ b/drivers/cpufreq/acpi-cpufreq.c
> > @@ -465,8 +465,8 @@ static int acpi_cpufreq_target(struct cpufreq_policy *policy,
> >  	return result;
> >  }
> >  
> > -unsigned int acpi_cpufreq_fast_switch(struct cpufreq_policy *policy,
> > -				      unsigned int target_freq)
> > +static unsigned int acpi_cpufreq_fast_switch(struct cpufreq_policy *policy,
> > +					     unsigned int target_freq)
> >  {
> >  	struct acpi_cpufreq_data *data = policy->driver_data;
> >  	struct acpi_processor_performance *perf;
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> 
> 

Patch applied, thanks!