linux-kernel - Re: [PATCH] firmware: qcom: scm: add a dummy qcom_scm_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Jun 2018 08:55:21 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Niklas Cassel <niklas.cassel@...aro.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        Avaneesh Kumar Dwivedi <akdwived@...eaurora.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Jordan Crouse <jcrouse@...eaurora.org>,
        Govind Singh <govinds@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: qcom: scm: add a dummy qcom_scm_assign_mem()

On Tue 12 Jun 06:23 PDT 2018, Niklas Cassel wrote:

> Add a dummy qcom_scm_assign_mem() to enable building drivers when
> CONFIG_COMPILE_TEST=y && CONFIG_QCOM_SCM=n.
> 
> All other qcom_scm_* functions already have a dummy version.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@...aro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
>  include/linux/qcom_scm.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h
> index da63d84e1e91..06996ad4f2bc 100644
> --- a/include/linux/qcom_scm.h
> +++ b/include/linux/qcom_scm.h
> @@ -89,6 +89,10 @@ static inline int qcom_scm_pas_mem_setup(u32 peripheral, phys_addr_t addr,
>  static inline int
>  qcom_scm_pas_auth_and_reset(u32 peripheral) { return -ENODEV; }
>  static inline int qcom_scm_pas_shutdown(u32 peripheral) { return -ENODEV; }
> +static inline int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t mem_sz,
> +				      unsigned int *src,
> +				      struct qcom_scm_vmperm *newvm,
> +				      int dest_cnt) { return -ENODEV; }
>  static inline void qcom_scm_cpu_power_down(u32 flags) {}
>  static inline u32 qcom_scm_get_version(void) { return 0; }
>  static inline u32
> -- 
> 2.17.1
>