linux-kernel - Re: [PATCH v4 2/7] clk: at91: add I2S clock mux driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <152882120419.16708.16947882037246176868@swboyd.mtv.corp.google.com>
Date:   Tue, 12 Jun 2018 09:33:24 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>,
        alexandre.belloni@...tlin.com, alsa-devel@...a-project.org,
        boris.brezillon@...tlin.com, broonie@...nel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        nicolas.ferre@...rochip.com, robh+dt@...nel.org
Cc:     Cristian.Birsan@...rochip.com
Subject: Re: [PATCH v4 2/7] clk: at91: add I2S clock mux driver

Quoting Codrin Ciubotariu (2018-06-04 01:20:29)
> On 31.05.2018 18:26, Stephen Boyd wrote:
> > Quoting Codrin Ciubotariu (2018-05-25 05:34:23)
> > 
> >> +       .get_parent = clk_i2s_mux_get_parent,
> >> +       .set_parent = clk_i2s_mux_set_parent,
> >> +       .determine_rate = __clk_mux_determine_rate,
> >> +};
> >> +
> >> +static struct clk_hw * __init
> >> +at91_clk_i2s_mux_register(struct regmap *regmap, const char *name,
> >> +                         const char * const *parent_names,
> >> +                         unsigned int num_parents, u32 bus_id)
> >> +{
> >> +       struct clk_init_data init = {};
> >> +       struct clk_i2s_mux *i2s_ck;
> >> +       int ret;
> >> +
> >> +       i2s_ck = kzalloc(sizeof(*i2s_ck), GFP_KERNEL);
> >> +       if (!i2s_ck)
> >> +               return ERR_PTR(-ENOMEM);
> >> +
> >> +       init.name = name;
> >> +       init.ops = &clk_i2s_mux_ops;
> >> +       init.parent_names = parent_names;
> >> +       init.num_parents = num_parents;
> >> +       init.flags = CLK_IGNORE_UNUSED;
> > 
> > Really? Why?
> 
> I am thinking that there is no need to gate this clock, since there is 
> no way to gate this clock in HW.

This flag is not necessary if the clk can't be gated via hardware
control registers. Please remove the flag.