linux-kernel - Re: [PATCH 1/4] Staging:rtl8192e Replace function names by using __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfKBkZ3znZn4YQPyOCrzT8aKZ0OAFTP2uErhoEgD13Z+A@mail.gmail.com>
Date:   Tue, 12 Jun 2018 20:01:54 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Janani Sankara Babu <jananis37@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johannes Berg <johannes.berg@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Kees Cook <keescook@...omium.org>, Rene.Hickersberger@....at,
        devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] Staging:rtl8192e Replace function names by using
 __func__ identifier

On Fri, Jun 8, 2018 at 7:32 AM, Janani Sankara Babu <jananis37@...il.com> wrote:
> This patch is created to solve the warning shown by checkpatch script
> Prefer using '"%s...", __func__' to using ', this function's name,
> in a string

Have you even tried to compile it?

NAK

>
> Signed-off-by: Janani Sankara Babu <jananis37@...il.com>
> ---
>  drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index c466a5e7..3c7ba33 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -127,7 +127,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,
>         }
>
>  #ifdef VERBOSE_DEBUG
> -       print_hex_dump_bytes("rtllib_ADDBA(): ", DUMP_PREFIX_NONE, skb->data,
> +       print_hex_dump_bytes("%s(): ", __func__, DUMP_PREFIX_NONE, skb->data,
>                              skb->len);
>  #endif
>         return skb;
> @@ -178,7 +178,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst,
>         tag += 2;
>
>  #ifdef VERBOSE_DEBUG
> -       print_hex_dump_bytes("rtllib_DELBA(): ", DUMP_PREFIX_NONE, skb->data,
> +       print_hex_dump_bytes("%s(): ", __func__, DUMP_PREFIX_NONE, skb->data,
>                              skb->len);
>  #endif
>         return skb;
> @@ -243,7 +243,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
>         }
>
>  #ifdef VERBOSE_DEBUG
> -       print_hex_dump_bytes("rtllib_rx_ADDBAReq(): ", DUMP_PREFIX_NONE,
> +       print_hex_dump_bytes("%s(): ", __func__, DUMP_PREFIX_NONE,
>                              skb->data, skb->len);
>  #endif
>
> @@ -441,7 +441,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
>         }
>
>  #ifdef VERBOSE_DEBUG
> -       print_hex_dump_bytes("rtllib_rx_DELBA(): ", DUMP_PREFIX_NONE, skb->data,
> +       print_hex_dump_bytes("%s():", __func__, DUMP_PREFIX_NONE, skb->data,
>                              skb->len);
>  #endif
>         delba = (struct rtllib_hdr_3addr *)skb->data;
> --
> 1.9.1
>



-- 
With Best Regards,
Andy Shevchenko