linux-kernel - Re: [PATCH v3 6/9] x86: prevent inline distortion by paravirt ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Jun 2018 03:49:37 +0000
From:   Nadav Amit <namit@...are.com>
To:     Peter Zijlstra <peterz@...radead.org>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        the arch/x86 maintainers <x86@...nel.org>,
        Juergen Gross <jgross@...e.com>,
        Alok Kataria <akataria@...are.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH v3 6/9] x86: prevent inline distortion by paravirt ops

at 12:45 AM, Peter Zijlstra <peterz@...radead.org> wrote:

> On Sun, Jun 10, 2018 at 07:19:08AM -0700, Nadav Amit wrote:
>> +/*
>> + * This generates an indirect call based on the operation type number.
>> + * The type number, computed in PARAVIRT_PATCH, is derived from the
>> + * offset into the paravirt_patch_template structure, and can therefore be
>> + * freely converted back into a structure offset.
>> + */
>> +.macro PARAVIRT_ALT type:req clobber:req pv_opptr:req
> 
> Unlike the marcro maze you replaced, this has the CALL hardcoded in. So
> maybe name this PARAVIRT_CALL instead of PARAVIRT_ALT ?

Sure. I will also merge the C macros of _paravirt_alt with paravirt_alt
and remove the former.