[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180613092955.vc5impf46prhcur7@mwanda>
Date: Wed, 13 Jun 2018 12:29:55 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Chris Opperman <eklikeroomys@...il.com>
Cc: devel@...verdev.osuosl.org, Frank Mori Hess <fmh6jj@...il.com>,
Simo Koskinen <koskisoft@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-kernel@...r.kernel.org, Ian Abbott <abbotti@....co.uk>
Subject: Re: [PATCH v4] staging: comedi: Improved readability of function
comedi_nsamples_left.
Sooooooooo close...
On Tue, Jun 12, 2018 at 11:09:44PM +0200, Chris Opperman wrote:
> Changes since v3:
> a) Reverted u64 to unsigned long long and u32 to unsigned int.
> b) Added patch versioning.
> c) Changed type of scans_left to unsigned long long to avoid cast.
> d) Clarified and updated changelog.
>
> >8-----------------------------------------------------------------------8<
This part here needs to go ...
>
> Improve readability of comedi_nsamples_left:
> a) Reduce nesting by using more return statements.
> b) Declare variables scans_left and samples_left at start of function.
> c) Change type of scans_Left to unsigned long long to avoid cast.
^
>
> Signed-off-by: Chris Opperman <eklikeroomys@...il.com>
> ---
... down here, under the --- cut off line.
> drivers/staging/comedi/drivers.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
regards,
dan carpenter
Powered by blists - more mailing lists