linux-kernel - Re: [PATCH v2 2/3] scsi: check for equality of result byte values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180613115808.GB12438@infradead.org>
Date:   Wed, 13 Jun 2018 04:58:08 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] scsi: check for equality of result byte values

On Wed, Jun 13, 2018 at 09:53:48AM +0200, Johannes Thumshirn wrote:
> When evaluating a SCSI command's result using the field access macros,
> check for equality of the fields and not if a specific bit is set.
> 
> This is a preparation patch, for reworking the results field in the
> SCSI command.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>