linux-kernel - Re: [PATCH v2 2/3] scsi: check for equality of result byte values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dcd5c76a5d9c2dd376bf7186376c7130889ebaa7.camel@wdc.com>
Date:   Wed, 13 Jun 2018 13:09:06 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "jthumshirn@...e.de" <jthumshirn@...e.de>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] scsi: check for equality of result byte values

On Wed, 2018-06-13 at 09:53 +0200, Johannes Thumshirn wrote:
>  		if ((cmd->result == (DID_OK << 16)
> -		     || status_byte(cmd->result) &
> -		     CHECK_CONDITION)) {
> +		     || status_byte(cmd->result) == CHECK_CONDITION)) {

A minor comment: the preferred coding style is to place "||" at the end of the
previous line.

> -		if ((driver_byte(the_result) & DRIVER_SENSE) == 0) {
> +		if (driver_byte(the_result) == DRIVER_SENSE) {

This change looks wrong to me.

Bart.