linux-kernel - Re: [PATCH] ARM64: dts: rockchip: add some pins to rk3399

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9584bfe-a098-1b90-2660-c27f82ed513c@rock-chips.com>
Date:   Wed, 13 Jun 2018 22:44:08 +0800
From:   Shawn Lin <shawn.lin@...k-chips.com>
To:     klaus.goger@...obroma-systems.com, Randy Li <ayaka@...lik.info>
Cc:     shawn.lin@...k-chips.com, linux-rockchip@...ts.infradead.org,
        Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Heiko Stuebner <heiko@...ech.de>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM64: dts: rockchip: add some pins to rk3399

On 2018/6/13 2:21, klaus.goger@...obroma-systems.com wrote:
> Hi Randy,

-----8<-------------

>> 		pcie {
>> +			pcie_clkreqn: pci-clkreqn {
>> +				rockchip,pins =
>> +					<2 26 RK_FUNC_2 &pcfg_pull_none>;
>> +			};
>> +
>> +			pcie_clkreqnb: pci-clkreqnb {
>> +				rockchip,pins =
>> +					<4 24 RK_FUNC_1 &pcfg_pull_none>;
>> +			};
>> +
> 
> I’m not sure if pci-clkreqn is functional at all. If not I’m not sure if we should add it to the dtsi.
> Shawn may know more about it.

Please refer to commit 461a00bb9d539e
("arm64: dts: rockchip: kill pcie_clkreqn and pcie_clkreqnb for rk3399")

CLKREQ# is used for PCI-PM L1.x, but it's not functional for rk3399, so
we have to support CPM(clock power management), thus I kill them last
year.

> 
>> 			pcie_clkreqn_cpm: pci-clkreqn-cpm {
>> 				rockchip,pins =
>> -					<2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>;
>> +					<2 26 RK_FUNC_GPIO &pcfg_pull_none>;
>> 			};
>>
>> 			pcie_clkreqnb_cpm: pci-clkreqnb-cpm {
>> 				rockchip,pins =
>> -					<4 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
>> +					<4 24 RK_FUNC_GPIO &pcfg_pull_none>;
>> 			};
>> 		};
>>
>> -- 
>> 2.14.4
> 
> 
> Could we actually use RK_Pxx for all new pin definitions? Would increase readability a lot.
> 
> Thanks,
> Klaus
> 
> 


-- 
Best Regards
Shawn Lin