linux-kernel - Re: [PATCH v4 2/2] gpio: davinci: Do not assume continuous IRQ numbering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37cadc4b-7fc6-5909-b499-7e747a7ee1cd@ti.com>
Date:   Wed, 13 Jun 2018 12:25:04 -0500
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Keerthy <j-keerthy@...com>, <linus.walleij@...aro.org>
CC:     <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <t-kristo@...com>
Subject: Re: [PATCH v4 2/2] gpio: davinci: Do not assume continuous IRQ
 numbering



On 06/12/2018 10:40 PM, Keerthy wrote:
> Currently the driver assumes that the interrupts are continuous
> and does platform_get_irq only once and assumes the rest are continuous,
> instead call platform_get_irq for all the interrupts and store them
> in an array for later use.
> 
> Signed-off-by: Keerthy <j-keerthy@...com>
> ---
> Tested for GPIO Interrupts on da850-lcdk board.
> 
> Changes in v4:
> 
>    * Corrected the gpio offset calculation from irq number
>      using the lookup.
> 
> Changes in v3:
> 
>    * Changed irqs type from unsigned to int
> 
> Changes in v2:
> 
>    * Extended the logic of using saved IRQs to unbanked IRQs
>      as per Grygorii's suggestion.
> 
>   drivers/gpio/gpio-davinci.c                | 63 ++++++++++++++++++++----------
>   include/linux/platform_data/gpio-davinci.h |  3 +-
>   2 files changed, 44 insertions(+), 22 deletions(-)
> 

Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

-- 
regards,
-grygorii