linux-kernel - Re: [PATCH 3/7] vmw_balloon: fix inflation of 64-bit GFNs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180613182137.GC29631@kroah.com>
Date:   Wed, 13 Jun 2018 20:21:37 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nadav Amit <namit@...are.com>
Cc:     Xavier Deguillard <xdeguillard@...are.com>,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 3/7] vmw_balloon: fix inflation of 64-bit GFNs

On Wed, Jun 13, 2018 at 04:03:55AM -0700, Nadav Amit wrote:
> When balloon batching is not supported by the hypervisor, the guest
> frame number (GFN) must fit in 32-bit. However, due to a bug, this check
> was mistakenly ignored. In practice, when total RAM is greater than
> 16TB, the balloon does not work currently, making this bug unlikely to
> happen.
> 
> Fixes: ef0f8f112984 ("VMware balloon: partially inline
> vmballoon_reserve_page.")
> 

Why have a bugfix as the 3rd patch of the series?  Please put it first,
so that it can get into Linus's tree sooner.

Also, no need to line-wrap this, and drop the blank line.

And finally, does this need to go to the stable kernels?  If so, please
add the correct line for that.

thanks,

greg k-h