linux-kernel - Re: [PATCH 3/7] vmw_balloon: fix inflation of 64-bit GFNs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5AE4EB83-47A7-45CB-A5A5-D25607A808BE@vmware.com>
Date:   Wed, 13 Jun 2018 18:27:22 +0000
From:   Nadav Amit <namit@...are.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Xavier Deguillard <xdeguillard@...are.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 3/7] vmw_balloon: fix inflation of 64-bit GFNs

at 11:21 AM, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> On Wed, Jun 13, 2018 at 04:03:55AM -0700, Nadav Amit wrote:
>> When balloon batching is not supported by the hypervisor, the guest
>> frame number (GFN) must fit in 32-bit. However, due to a bug, this check
>> was mistakenly ignored. In practice, when total RAM is greater than
>> 16TB, the balloon does not work currently, making this bug unlikely to
>> happen.
>> 
>> Fixes: ef0f8f112984 ("VMware balloon: partially inline
>> vmballoon_reserve_page.")
> 
> Why have a bugfix as the 3rd patch of the series?  Please put it first,
> so that it can get into Linus's tree sooner.
> 
> Also, no need to line-wrap this, and drop the blank line.
> 
> And finally, does this need to go to the stable kernels?  If so, please
> add the correct line for that.

I will fix the message. Patches 3-7 deal with minor bugs, some of which have
been there since day one, so I didn’t put a “Fixes” tag.

I’ll follow your direction and put patches 1-2 at the end.