linux-kernel - Re: [PATCH v7 4/4] vsprintf: Add command line option debug_boot_weak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180613150154.61b52e05@gandalf.local.home>
Date:   Wed, 13 Jun 2018 15:01:54 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 4/4] vsprintf: Add command line option
 debug_boot_weak_hash

On Tue, 12 Jun 2018 10:39:14 +1000
"Tobin C. Harding" <me@...in.cc> wrote:


> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index c445f9f28760..6d2479eb7c2b 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -1651,6 +1651,18 @@ char *device_node_string(char *buf, char *end, struct device_node *dn,
>  	return widen_string(buf, buf - buf_start, end, spec);
>  }
>  
> +/* Make pointers available for printing early in the boot sequence. */
> +static int debug_boot_weak_hash __ro_after_init;
> +EXPORT_SYMBOL(debug_boot_weak_hash);


I was too busy trying to make this use a static_branch, that I forgot
to mention this in my review.

Why did you add that EXPORT_SYMBOL()? It's useless with a static
variable. I think you can nuke that line.

-- Steve