linux-kernel - Re: [PATCH] scsi: cxlflash: Change return type for fault handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180613232347.GA3851@p8tul1-build.aus.stglabs.ibm.com>
Date:   Wed, 13 Jun 2018 18:23:47 -0500
From:   "Matthew R. Ochs" <mrochs@...ux.vnet.ibm.com>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     willy@...radead.org, manoj@...ux.vnet.ibm.com,
        ukrishn@...ux.vnet.ibm.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, sabyasachi.linux@...il.com,
        brajeswar.linux@...il.com
Subject: Re: [PATCH] scsi: cxlflash: Change return type for fault handler

On Tue, Jun 12, 2018 at 01:12:04AM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
> 
> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>

This looks fine to me.

FYI that there is another handler for this driver in a series
destined for 4.18 and currently in next/master.

Acked-by: Matthew R. Ochs <mrochs@...ux.vnet.ibm.com>