linux-kernel - Re: [PATCH v2] Fixed a checkpatch error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180614064229.GA12429@kroah.com>
Date:   Thu, 14 Jun 2018 08:42:29 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Parth Y Shah <sparth1292@...il.com>
Cc:     balbi@...nel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Fixed a checkpatch error

On Thu, Jun 14, 2018 at 12:02:46PM +0530, Parth Y Shah wrote:
> ERROR: code indent should use tabs where possible
> 
> Here, spaces are replaced by a tab in 2 lines.
> 
> Signed-off-by: Parth Y Shah <sparth1292@...il.com>

Your subject line needs work, please see how other subject lines are
composed for this subsystem.

Also note, please do not use anything but the drivers/staging/ area of
the kernel for beginning "I'm going to do checkpatch cleanups" type of
"learning to get changes into the kernel" work.  That is a great place
to start with this, not in other subsystems where you might have
reviewers who do not care so much about whitespace cleanups like this.

So please learn the process there, and when you have it all working
well, then you could move on to other subsystems and areas of the
kernel, like this one, if you want to.

thanks,

greg k-h