linux-kernel - Re: [PATCH] ACPI : dock: add error handling for acpi_bus_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hjRsVVnvO0rBFxXesTDuE8M+W1YwwAYHp67RMMRikckA@mail.gmail.com>
Date:   Thu, 14 Jun 2018 09:54:40 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Zhouyang Jia <jiazhouyang09@...il.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI : dock: add error handling for acpi_bus_get_device

On Tue, Jun 12, 2018 at 6:38 AM, Zhouyang Jia <jiazhouyang09@...il.com> wrote:
> When acpi_bus_get_device fails, the lack of error-handling code may
> cause unexpected results.

It is perfectly predictable in this particular case: adev will be NULL
and acpi_device_enumerated(adev) will return false.

> This patch adds error-handling code after calling acpi_bus_get_device.

Which is not necessary.

Thanks,
Rafael