linux-kernel - Re: [PATCH v2] pcmcia: add error handling for pcmcia_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf7tbfR5eN4JN2Dph_2qzA=eU2r3S5BfRLH6=vN1+U6ng@mail.gmail.com>
Date:   Thu, 14 Jun 2018 12:39:37 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Zhouyang Jia <jiazhouyang09@...il.com>
Cc:     "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Hannes Reinecke <hare@...e.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] pcmcia: add error handling for pcmcia_enable_device

On Thu, Jun 14, 2018 at 12:23 PM, Zhouyang Jia <jiazhouyang09@...il.com> wrote:
> When pcmcia_enable_device fails, the lack of error-handling code may
> cause unexpected results.

What results?
You need to elaborate this.,

> This patch adds error-handling code after calling pcmcia_enable_device.

> +       int ret;
> +
> +       ret = pcmcia_enable_device(link);
> +       if (ret)
> +               return -ENODEV;

And why not to return ret?

-- 
With Best Regards,
Andy Shevchenko