linux-kernel - Re: [PATCH v1] aio: mark __aio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180614121628.GA27117@lst.de>
Date:   Thu, 14 Jun 2018 14:16:28 +0200
From:   Christoph Hellwig <hch@....de>
To:     Alexander Viro <viro@...iv.linux.org.uk>,
        Avi Kivity <avi@...lladb.com>,
        Benjamin LaHaise <bcrl@...ck.org>,
        linux-fsdevel@...r.kernel.org, linux-aio@...ck.org,
        linux-kernel@...r.kernel.org, hch@....de
Subject: Re: [PATCH v1] aio: mark __aio_sigset::sigmask const

On Fri, Jun 08, 2018 at 05:55:05PM +0300, Avi Kivity wrote:
> io_pgetevents() will not change the signal mask. Mark it const
> to make it clear and to reduce the need for casts in user code.
> 
> Signed-off-by: Avi Kivity <avi@...lladb.com>

Al, can you pick this one and the masking fix before -rc1?

> ---
>  include/uapi/linux/aio_abi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/aio_abi.h b/include/uapi/linux/aio_abi.h
> index ed0185945bb2..cdf115b03761 100644
> --- a/include/uapi/linux/aio_abi.h
> +++ b/include/uapi/linux/aio_abi.h
> @@ -106,11 +106,11 @@ struct iocb {
>  
>  #undef IFBIG
>  #undef IFLITTLE
>  
>  struct __aio_sigset {
> -	sigset_t __user	*sigmask;
> +	const sigset_t __user	*sigmask;
>  	size_t		sigsetsize;
>  };
>  
>  #endif /* __LINUX__AIO_ABI_H */
>  
> -- 
> 2.14.4
---end quoted text---