linux-kernel - Re: [PATCH 2/2] ALSA: usb-audio: UAC3. Add insertion control for BADD.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hvaal35tx.wl-tiwai@suse.de>
Date:   Thu, 14 Jun 2018 14:34:02 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Jorge Sanjuan <jorge.sanjuan@...ethink.co.uk>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        ruslan.bilovol@...il.com
Subject: Re: [PATCH 2/2] ALSA: usb-audio: UAC3. Add insertion control for BADD.

On Tue, 12 Jun 2018 16:32:01 +0200,
Jorge Sanjuan wrote:
> 
> The HEADSET ADAPTER profile for BADD devices is meant to support
> Insertion Control for the Input and Output Terminals of the headset.
> Furthermore, this profile may also include the interrupt status pipe
> to report changes on these terminals.
> 
> This patch creates the jack-detect controls for the Headset Adapter
> profile and enables the interrupt status pipe creation for BADD devices.
> 
> Signed-off-by: Jorge Sanjuan <jorge.sanjuan@...ethink.co.uk>

The changes look good, but I'd prefer splitting this:

- A preliminary work to change get_connector_control_name() and
  build_connector_control() to receive usb_mixer_interface;
  this is no functional change

- Add build_connector_control() calls for UAC3 BADD

- Apply snd_usb_mixer_status_create() for UAC3 BADD, too
  

thanks,

Takashi